MIGSMSFT-765 & MIGSMSFT-778 Sequential udp ports for different priorities #15755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
sdszhang
reviewed
Nov 27, 2024
| @@ -345,6 +340,11 @@ def __gen_data_flow(testbed_config, | |||
| elif 'Test Flow 2 -> 0' in flow.name: | |||
| eth.pfc_queue.value = pfcQueueValueDict[flow_prio[1]] | |||
|
|
|||
| src_port = 5000 + eth.pfc_queue.value * 1000 | |||
There was a problem hiding this comment.
- can you use a global variable for the starting port
5000 - I would prefer to remove the *1000 steps, just use
5000 + eth.pfc_queue.value. For two flows, port 5000 and 6000 may still hash to the same port, but 5000 and 5001 are unlikely to be hashed to same port in most platform.
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
sdszhang
approved these changes
Nov 27, 2024
zhixzhu
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 29, 2024
…ties (sonic-net#15755) Description of PR Summary: Fixes # (issue) https://migsonic.atlassian.net/browse/MIGSMSFT-765 https://migsonic.atlassian.net/browse/MIGSMSFT-778 Approach What is the motivation for this PR? Fixed udp ports selection, make test result stable. How did you do it? Remove random. How did you verify/test it? Verified it on T2 ixia testbed. =============================================================== PASSES ================================================================ _________________________________________ test_m2o_fluctuating_lossless[multidut_port_info0] __________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-04-55/tr_2024-11-27-01-04-55.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:14:00 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfc/test_m2o_fluctuating_lossless.py::test_m2o_fluctuating_lossless[multidut_port_info0] ============================================== 1 passed, 4 warnings in 542.83s (0:09:02) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ =============================================================== PASSES ================================================================ ___________________________________________ test_pfcwd_runtime_traffic[multidut_port_info0] ___________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-19-10/tr_2024-11-27-01-19-10.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:28:10 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.py::test_pfcwd_runtime_traffic[multidut_port_info0] ============================================== 1 passed, 4 warnings in 538.55s (0:08:58) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
|
Cherry-pick PR to 202405: #15805 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 29, 2024
…ties (#15755) Description of PR Summary: Fixes # (issue) https://migsonic.atlassian.net/browse/MIGSMSFT-765 https://migsonic.atlassian.net/browse/MIGSMSFT-778 Approach What is the motivation for this PR? Fixed udp ports selection, make test result stable. How did you do it? Remove random. How did you verify/test it? Verified it on T2 ixia testbed. =============================================================== PASSES ================================================================ _________________________________________ test_m2o_fluctuating_lossless[multidut_port_info0] __________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-04-55/tr_2024-11-27-01-04-55.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:14:00 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfc/test_m2o_fluctuating_lossless.py::test_m2o_fluctuating_lossless[multidut_port_info0] ============================================== 1 passed, 4 warnings in 542.83s (0:09:02) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ =============================================================== PASSES ================================================================ ___________________________________________ test_pfcwd_runtime_traffic[multidut_port_info0] ___________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-19-10/tr_2024-11-27-01-19-10.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:28:10 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.py::test_pfcwd_runtime_traffic[multidut_port_info0] ============================================== 1 passed, 4 warnings in 538.55s (0:08:58) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 29, 2024
…ties (sonic-net#15755) Description of PR Summary: Fixes # (issue) https://migsonic.atlassian.net/browse/MIGSMSFT-765 https://migsonic.atlassian.net/browse/MIGSMSFT-778 Approach What is the motivation for this PR? Fixed udp ports selection, make test result stable. How did you do it? Remove random. How did you verify/test it? Verified it on T2 ixia testbed. =============================================================== PASSES ================================================================ _________________________________________ test_m2o_fluctuating_lossless[multidut_port_info0] __________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-04-55/tr_2024-11-27-01-04-55.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:14:00 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfc/test_m2o_fluctuating_lossless.py::test_m2o_fluctuating_lossless[multidut_port_info0] ============================================== 1 passed, 4 warnings in 542.83s (0:09:02) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ =============================================================== PASSES ================================================================ ___________________________________________ test_pfcwd_runtime_traffic[multidut_port_info0] ___________________________________________ ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-27-01-19-10/tr_2024-11-27-01-19-10.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 01:28:10 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.py::test_pfcwd_runtime_traffic[multidut_port_info0] ============================================== 1 passed, 4 warnings in 538.55s (0:08:58) ============================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
https://migsonic.atlassian.net/browse/MIGSMSFT-765
https://migsonic.atlassian.net/browse/MIGSMSFT-778
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixed udp ports selection, make test result stable.
How did you do it?
Remove random.
How did you verify/test it?
Verified it on T2 ixia testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation