Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tacacs] increase timeout value for accounting test and ignore loganalyzer #15759

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

maipbui
Copy link
Contributor

@maipbui maipbui commented Nov 27, 2024

Description of PR

Summary: increase timeout value for accounting test and ignore loganalyzer
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Mai Bui <maibui@microsoft.com>
@qiluo-msft qiluo-msft requested a review from liuh-80 November 27, 2024 21:26
logger.debug("auditctl: %s", auditctl)
audisp_log = duthost.shell("show logg | grep audisp-syslog")
logger.debug("audisp-syslog log: %s", audisp_log)
audisp_log = duthost.shell('show logg | grep audisp-syslog | grep tacplus | grep test_rwuser')
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show log

why show logg twice? Is above command already include everything the second command generate? #Closed

Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
@maipbui maipbui changed the title [tacacs] add debug logs for accounting test [tacacs] increase timeout value for accounting test and ignore loganalyzer Dec 3, 2024
@maipbui
Copy link
Contributor Author

maipbui commented Dec 3, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit df76e3e into sonic-net:master Dec 3, 2024
16 checks passed
@maipbui maipbui deleted the debug_tacacs_accounting branch December 3, 2024 19:13
@maipbui
Copy link
Contributor Author

maipbui commented Dec 3, 2024

@bingwang-ms can you help cherry pick to 202405?

@mssonicbld
Copy link
Collaborator

@maipbui PR conflicts with 202405 branch

@maipbui
Copy link
Contributor Author

maipbui commented Dec 3, 2024

cherry-pick PR 202405 - #15857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants