Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco specific: Check debug shell status before ecn marking test #15934

Merged

Conversation

sreejithsreekumaran
Copy link
Contributor

@sreejithsreekumaran sreejithsreekumaran commented Dec 6, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Testcase execution might fail if a previous test did a config reload
which results in delay of dshell init which is expected.

How did you do it?

Added a pytest fixture to run along with testcase.

How did you verify/test it?

on Snappi based run

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@alpeshspatel
Copy link
Contributor

fyi: @abdosi @sdszhang This fixes the ixia ECN test case

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@auspham
Copy link
Contributor

auspham commented Dec 9, 2024

@sreejithsreekumaran could you help resolve conflict

@yejianquan
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit 2e62e24 into sonic-net:master Dec 11, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 11, 2024
…ic-net#15934)

Description of PR
Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
Testcase execution might fail if a previous test did a config reload
which results in delay of dshell init which is expected.

How did you do it?
Added a pytest fixture to run along with testcase.

How did you verify/test it?
on Snappi based run

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16009

mssonicbld pushed a commit that referenced this pull request Dec 11, 2024
)

Description of PR
Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
Testcase execution might fail if a previous test did a config reload
which results in delay of dshell init which is expected.

How did you do it?
Added a pytest fixture to run along with testcase.

How did you verify/test it?
on Snappi based run

co-authorized by: jianquanye@microsoft.com
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 3, 2025
…ic-net#15934)

Description of PR
Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
Testcase execution might fail if a previous test did a config reload
which results in delay of dshell init which is expected.

How did you do it?
Added a pytest fixture to run along with testcase.

How did you verify/test it?
on Snappi based run

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16333

mssonicbld pushed a commit that referenced this pull request Jan 3, 2025
)

Description of PR
Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
Testcase execution might fail if a previous test did a config reload
which results in delay of dshell init which is expected.

How did you do it?
Added a pytest fixture to run along with testcase.

How did you verify/test it?
on Snappi based run

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants