[platform_tests/test_reload_config]: Respect overridden timeout #16031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Respect overridden timeout for reboot in reload_configuration_checks_test * Replace plt_override option with wait_for_processes - will bail early after SSH is up if not set * Don't check all containers for t2 / modular chassis * Increase timeouts Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liamkearney-msft
requested review from
auspham,
arlakshm and
wenyiz2021
and removed request for
prgeor
Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
auspham
approved these changes
Dec 13, 2024
arlakshm
previously approved these changes
Dec 13, 2024
|
/Azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
|
Please share the test result for non-chassis platforms. The other PR #15951 caused regression on non-chassis platform |
|
Hi @bingwang-ms, please see attached pass run on t1: |
liamkearney-msft
dismissed stale reviews from arlakshm and yejianquan
via
10fda92
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There are various failures seen on nokia 7250 / arista 7800 / modular chassis DUTs for test_reload_config tests. Generally, they can be attributed to two things: too short of a timeout for t2 chassis, and the new docker status check.
How did you do it?
This PR refactors some logic in the reboot command, such that it will now respect overwritten values for the reboot timeout in the inventory file (so that SKU specific tweaks can be properly specified), and also repurposes the
plt_reboot_ctrl_overwriteparameter toreturn_after_reconnect, which if set will cause the reboot function to return early after SSH comes back up, which is more in the spirit of how the test functions.Additionally, some timeouts have been increased for this testcase, as t2 requires more time for services to come up.
Finally, the docker status check has been skipped for modular_chassis DUTs.
How did you verify/test it?
Ran on Nokia 7250 and Arista 7800 chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation