fix flaky issue in test_set_fans_speed #16162
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test result |
sdszhang
changed the title
8 tasks
yejianquan
pushed a commit
that referenced
this pull request
Dec 19, 2024
Cherry pick #16162 Description of PR Summary: Fixes wrong dut maybe selected to stop thermalctrl in chassis_fan tests. TestChassisFans::setup fixture will select the first DUT as the duthost to stop/start thermal control daemon. However, in the test case, it will enum_rand_one_per_hwsku_hostname to do the test. Therefore, we will see something like the following. that lc4 is being selected to stop thermalctld, but the test is running on supervisor. 16/12/2024 12:42:40 base._run L0071 DEBUG | /var/src/sonic-mgmt_xxx/tests/common/devices/sonic.py::stop_pmon_daemon_service#888: [xxx-lc4-1] AnsibleModule::shell, args=["docker exec pmon supervisorctl stop thermalctld"], kwargs={"module_ignore_errors": true} ...... 16/12/2024 12:42:54 __init__._log_sep_line L0170 INFO | ==================== platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_speed[xxx-sup-1] call ==================== Approach What is the motivation for this PR? flaky test case in test_set_fans_speed How did you do it? use enum_rand_one_per_hwsku_hostname instead of duthost to align with the test case. How did you verify/test it? ran the test 3 times, all passed. co-authorized by: jianquanye@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
Description of PR
Summary:
Fixes wrong dut maybe selected to stop thermalctrl in chassis_fan tests.
TestChassisFans::setup fixture will select the first DUT as the duthost to stop/start thermal control daemon.
However, in the test case, it will enum_rand_one_per_hwsku_hostname to do the test.
Therefore, we will see something like the following. that lc4 is being selected to stop thermalctld, but the test is running on supervisor.
16/12/2024 12:42:40 base._run L0071 DEBUG | /var/src/sonic-mgmt_xxx/tests/common/devices/sonic.py::stop_pmon_daemon_service#888: [xxx-lc4-1] AnsibleModule::shell, args=["docker exec pmon supervisorctl stop thermalctld"], kwargs={"module_ignore_errors": true}
......
16/12/2024 12:42:54 __init__._log_sep_line L0170 INFO | ==================== platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_speed[xxx-sup-1] call ====================
Approach
What is the motivation for this PR?
flaky test case in test_set_fans_speed
How did you do it?
use enum_rand_one_per_hwsku_hostname instead of duthost to align with the test case.
How did you verify/test it?
ran the test 3 times, all passed.
co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202411: #16298 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR
Summary:
Fixes wrong dut maybe selected to stop thermalctrl in chassis_fan tests.
TestChassisFans::setup fixture will select the first DUT as the duthost to stop/start thermal control daemon.
However, in the test case, it will enum_rand_one_per_hwsku_hostname to do the test.
Therefore, we will see something like the following. that lc4 is being selected to stop thermalctld, but the test is running on supervisor.
16/12/2024 12:42:40 base._run L0071 DEBUG | /var/src/sonic-mgmt_xxx/tests/common/devices/sonic.py::stop_pmon_daemon_service#888: [xxx-lc4-1] AnsibleModule::shell, args=["docker exec pmon supervisorctl stop thermalctld"], kwargs={"module_ignore_errors": true}
......
16/12/2024 12:42:54 __init__._log_sep_line L0170 INFO | ==================== platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_speed[xxx-sup-1] call ====================
Approach
What is the motivation for this PR?
flaky test case in test_set_fans_speed
How did you do it?
use enum_rand_one_per_hwsku_hostname instead of duthost to align with the test case.
How did you verify/test it?
ran the test 3 times, all passed.
co-authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
|
manual cherry-pick PR #16163 merged for 202405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes wrong dut maybe selected to stop thermalctrl in chassis_fan tests.
TestChassisFans::setup fixture will select the first DUT as the duthost to stop/start thermal control daemon.
However, in the test case, it will enum_rand_one_per_hwsku_hostname to do the test.
Therefore, we will see something like the following. that lc4 is being selected to stop thermalctld, but the test is running on supervisor.
Type of change
Back port request
Approach
What is the motivation for this PR?
flaky test case in test_set_fans_speed
How did you do it?
use enum_rand_one_per_hwsku_hostname instead of duthost to align with the test case.
How did you verify/test it?
ran the test 3 times, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation