Summary:New smartswitch DPU config template #16201

nnelluri-cisco · 2024-12-23T22:58:14Z

Description of PR

New smartswitch DPU config template.

Summary: smartswitch DPU config
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

configure the DPU's for the smartswicth.

How did you do it?

Added New dpu_config.j2 to generate DPU config for the smartswicth.

How did you verify/test it?

Verified using below command
./testbed-cli.sh deploy-mg cmono_t1 ./lab ./password.txt

Wednesday 20 November 2024  02:22:32 +0000 (0:00:00.374)       0:03:09.175 **** 
=============================================================================== 
execute cli "config load_minigraph --override_config -y" to apply new minigraph ------------------------------------------------------------------------------------------------------------- 79.14s
Sync DUT system time with NTP server -------------------------------------------------------------------------------------------------------------------------------------------------------- 61.89s
Wait for switch to become reachable again --------------------------------------------------------------------------------------------------------------------------------------------------- 10.28s
Configure TACACS with PTF TACACS server ------------------------------------------------------------------------------------------------------------------------------------------------------ 5.64s
Configure TACACS ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 5.57s
Start ntp.service on DUT --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 3.07s
execute cli "config save -y" to save current minigraph as startup-config --------------------------------------------------------------------------------------------------------------------- 2.47s
execute cli "config bgp startup all" to bring up all bgp sessions for test ------------------------------------------------------------------------------------------------------------------- 1.94s
Wait for ntp.service restart after reload minigraph ------------------------------------------------------------------------------------------------------------------------------------------ 1.61s
Set the RTC from the system time ------------------------------------------------------------------------------------------------------------------------------------------------------------- 1.20s
create new minigraph file for SONiC device --------------------------------------------------------------------------------------------------------------------------------------------------- 1.08s
Stop ntp.service on DUT ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1.06s
find interface name mapping and individual interface speed if defined from dut --------------------------------------------------------------------------------------------------------------- 1.05s
Generate server cert using openssl. ---------------------------------------------------------------------------------------------------------------------------------------------------------- 0.96s
active dpu config ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.76s
Generate dsmsroot cert using openssl. -------------------------------------------------------------------------------------------------------------------------------------------------------- 0.66s
create dpu config file for SONiC device ------------------------------------------------------------------------------------------------------------------------------------------------------ 0.56s
Generate server cert using openssl. ---------------------------------------------------------------------------------------------------------------------------------------------------------- 0.52s
gather testbed VM information ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.45s
Generate golden_config_db.json --------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.40s
Done

Any platform specific information?

hwsku: Cisco-8102-28FH-DPU-O-T1

Supported testbed topology if it's a new test case?

smartswicth

Documentation

mssonicbld · 2024-12-23T22:58:17Z

/azp run

linux-foundation-easycla · 2024-12-23T22:58:18Z

The committers listed above are authorized under a signed CLA.

✅ login: nnelluri-cisco (6dc9e0d, 0c09131, 0405766, 1d50ba0, a61bdf7, b49cac6, 0ba9bf8, 0e6ea4f, 9e80dd0, ad3b532, 65a3b0e)

azure-pipelines · 2024-12-23T22:58:28Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2024-12-23T23:01:48Z

@prabhataravind
Please review.

ansible/config_sonic_basedon_testbed.yml

mssonicbld · 2025-01-07T07:14:24Z

/azp run

azure-pipelines · 2025-01-07T07:14:30Z

Pull request contains merge conflicts.

nnelluri-cisco · 2025-01-07T07:28:30Z

@wen587
Generated DPU config using single file generate_golden_config_db.py. Please review

wen587 · 2025-01-08T02:05:22Z

Hi @nnelluri-cisco , I think there are some conflict where the master code has already support this Golden Config.
The problem is that is there platform or hwsku dependent variable to check how many dpu are there. I already know some are 4 and some are 8. Can we put this number in yml file, so that golden config can derive DPU related config based on dpu number?

nnelluri-cisco · 2025-01-08T05:13:15Z

Hi @nnelluri-cisco , I think there are some conflict where the master code has already support this Golden Config. The problem is that is there platform or hwsku dependent variable to check how many dpu are there. I already know some are 4 and some are 8. Can we put this number in yml file, so that golden config can derive DPU related config based on dpu number?

@wen587
I resolved merge conflicts, the conflict came due to editing same file.
Regarding DPU config we dont need yaml file , the file already defined below dict specific to cisco husku.

smartswitch_hwsku_config = {
"Cisco-8102-28FH-DPU-O-T1": {
"dpu_num": 8,
"port_key": "Ethernet-BP{}",
"interface_key": "Ethernet-BP{}|18.{}.202.0/31",
"dpu_key": "dpu{}"
}
}

mssonicbld · 2025-01-08T05:39:55Z

/azp run

azure-pipelines · 2025-01-08T05:40:09Z

Azure Pipelines successfully started running 1 pipeline(s).

ansible/library/generate_golden_config_db.py

…ag.json"

mssonicbld · 2025-01-08T06:30:29Z

/azp run

azure-pipelines · 2025-01-08T06:30:42Z

Azure Pipelines successfully started running 1 pipeline(s).

ansible/library/generate_golden_config_db.py

mssonicbld · 2025-01-08T17:19:48Z

/azp run

azure-pipelines · 2025-01-08T17:20:02Z

Azure Pipelines successfully started running 1 pipeline(s).

… table in generate_golden_config_db.py

mssonicbld · 2025-01-09T05:51:05Z

/azp run

azure-pipelines · 2025-01-09T05:51:16Z

Azure Pipelines successfully started running 1 pipeline(s).

bpar9

lgtm

mssonicbld · 2025-01-09T21:02:55Z

/azp run

azure-pipelines · 2025-01-09T21:03:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T21:18:55Z

/azp run

azure-pipelines · 2025-01-09T21:19:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T22:14:58Z

/azp run

azure-pipelines · 2025-01-09T22:15:11Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T22:29:01Z

/azp run

azure-pipelines · 2025-01-09T22:29:13Z

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind · 2025-01-13T15:31:18Z

ansible/golden_config_db/smartswitch_t1-28-lag.json

-        }
-    },
-    "GNMI": {
+	"GNMI": {


@nnelluri-cisco can you check alignment here?

@prabhataravind
Fixed the alignment issue.

prabhataravind · 2025-01-13T15:35:12Z

@oleksandrivantsiv @JibinBao fyi

mssonicbld · 2025-01-13T23:26:18Z

/azp run

azure-pipelines · 2025-01-13T23:26:29Z

Azure Pipelines successfully started running 1 pipeline(s).

JibinBao · 2025-01-14T01:44:08Z

@oleksandrivantsiv @JibinBao fyi

thanks

prabhataravind

lgtm

zjswhhh

@r12f for your vis.

prabhataravind · 2025-01-18T00:30:50Z

/azpw run

Summary:New smartswitch DPU config template

0c09131

prabhataravind requested review from ganglyu and wen587 December 24, 2024 00:30

wen587 reviewed Dec 24, 2024

View reviewed changes

ansible/config_sonic_basedon_testbed.yml Outdated Show resolved Hide resolved

Summary: smartswitch DPU config

6dc9e0d

Merge branch 'master' into dpu-config

9e80dd0

wen587 reviewed Jan 8, 2025

View reviewed changes

ansible/library/generate_golden_config_db.py Show resolved Hide resolved

wen587 reviewed Jan 8, 2025

View reviewed changes

ansible/library/generate_golden_config_db.py Show resolved Hide resolved

Removed DPU config which already defined in file "smartswitch_t1-28-l…

b49cac6

…ag.json"

wen587 reviewed Jan 8, 2025

View reviewed changes

ansible/library/generate_golden_config_db.py Outdated Show resolved Hide resolved

Added DPU0 entry which is missing in original json file

0e6ea4f

removed the DPU table in smartswitch_t1-28-lag.json abd added the DPU…

0405766

… table in generate_golden_config_db.py

wen587 approved these changes Jan 9, 2025

View reviewed changes

bpar9 previously approved these changes Jan 9, 2025

View reviewed changes

Fixed flake8 errors in the code

0ba9bf8

nnelluri-cisco dismissed bpar9’s stale review via 0ba9bf8 January 9, 2025 21:02

Fixed flake8 errors in the code

65a3b0e

removing trailing-whitespace

a61bdf7

removing trailing-whitespace

ad3b532

bpar9 previously approved these changes Jan 9, 2025

View reviewed changes

prabhataravind reviewed Jan 13, 2025

View reviewed changes

Fixed alignment issue

1d50ba0

nnelluri-cisco dismissed bpar9’s stale review via 1d50ba0 January 13, 2025 23:26

wen587 approved these changes Jan 15, 2025

View reviewed changes

nnelluri-cisco requested a review from bpar9 January 15, 2025 16:57

prabhataravind approved these changes Jan 15, 2025

View reviewed changes

bingwang-ms approved these changes Jan 15, 2025

View reviewed changes

zjswhhh reviewed Jan 17, 2025

View reviewed changes

bingwang-ms merged commit eb7cc6f into sonic-net:master Jan 22, 2025
18 checks passed

Summary:New smartswitch DPU config template #16201

Summary:New smartswitch DPU config template #16201

Conversation

nnelluri-cisco commented Dec 23, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Dec 23, 2024

linux-foundation-easycla bot commented Dec 23, 2024 • edited Loading

azure-pipelines bot commented Dec 23, 2024

nnelluri-cisco commented Dec 23, 2024

mssonicbld commented Jan 7, 2025

azure-pipelines bot commented Jan 7, 2025

nnelluri-cisco commented Jan 7, 2025

wen587 commented Jan 8, 2025

nnelluri-cisco commented Jan 8, 2025 • edited Loading

mssonicbld commented Jan 8, 2025

azure-pipelines bot commented Jan 8, 2025

mssonicbld commented Jan 8, 2025

azure-pipelines bot commented Jan 8, 2025

mssonicbld commented Jan 8, 2025

azure-pipelines bot commented Jan 8, 2025

mssonicbld commented Jan 9, 2025

azure-pipelines bot commented Jan 9, 2025

bpar9 left a comment

Choose a reason for hiding this comment

mssonicbld commented Jan 9, 2025

azure-pipelines bot commented Jan 9, 2025

mssonicbld commented Jan 9, 2025

azure-pipelines bot commented Jan 9, 2025

mssonicbld commented Jan 9, 2025

azure-pipelines bot commented Jan 9, 2025

mssonicbld commented Jan 9, 2025

azure-pipelines bot commented Jan 9, 2025

prabhataravind Jan 13, 2025

Choose a reason for hiding this comment

nnelluri-cisco Jan 13, 2025

Choose a reason for hiding this comment

prabhataravind commented Jan 13, 2025

mssonicbld commented Jan 13, 2025

azure-pipelines bot commented Jan 13, 2025

JibinBao commented Jan 14, 2025

prabhataravind left a comment

Choose a reason for hiding this comment

zjswhhh left a comment

Choose a reason for hiding this comment

prabhataravind commented Jan 18, 2025

linux-foundation-easycla bot commented Dec 23, 2024 •

edited

Loading

nnelluri-cisco commented Jan 8, 2025 •

edited

Loading