Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic #16494

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Jan 13, 2025

Description of PR

Summary:
Fixes #16344

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
    • Add ownership here(Microsft required only)
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?

Modify test_interface_binding:

  1. Remove LLA for Vlans
  2. Restart dhcp_relay container
  3. Verify whether sockets for LLA are not established
  4. Add LLA back
  5. Verify whether sockets for LLA are established

How did you verify/test it?

Run test_dhcpv6_relay.py

collected 6 items                                                                                                                                                                                                                                                                  

dhcp_relay/test_dhcpv6_relay.py::test_interface_binding PASSED                                                                                                                                                                                                               [ 16%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcpv6_relay_counter PASSED                                                                                                                                                                                                            [ 33%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_default PASSED                                                                                                                                                                                                              [ 50%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_after_link_flap PASSED                                                                                                                                                                                                      [ 66%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_start_with_uplinks_down PASSED                                                                                                                                                                                              [ 83%]
dhcp_relay/test_dhcpv6_relay.py::TestDhcpv6RelayWithMultipleVlan::test_dhcp_relay_default[3] PASSED                                                                                                                                                                          [100%]

================================================================================================================================= warnings summary =================================================================================================================================
../../../../usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236
  /usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
    "class": algorithms.Blowfish,

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/dhcp_relay/test_dhcpv6_relay.xml ----------------------------------------------------------------------------------------------
===================================================================================================================== 6 passed, 1 warning in 967.94s (0:16:07) =====================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz force-pushed the azure-master_dhcp6relay_lla branch from c435f64 to c2b5829 Compare January 13, 2025 09:49
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz
Copy link
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 442e9c2 into sonic-net:master Jan 14, 2025
23 checks passed
@yaqiangz
Copy link
Contributor Author

Hi @bingwang-ms could you please help to approve this backport request?

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 16, 2025
…nic-net#16494)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16554

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 16, 2025
…nic-net#16494)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16556

yaqiangz added a commit to yaqiangz/sonic-mgmt that referenced this pull request Jan 17, 2025
…nic-net#16494)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
yaqiangz added a commit to yaqiangz/sonic-mgmt that referenced this pull request Jan 17, 2025
…ogic (sonic-net#16494)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
mssonicbld pushed a commit that referenced this pull request Jan 17, 2025
…6494)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
bingwang-ms pushed a commit that referenced this pull request Jan 17, 2025
…ogic (#16494) (#16567)

What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?
Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?
Run test_dhcpv6_relay.py
@yaqiangz
Copy link
Contributor Author

Backport for 202405: #16567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Gap][dhcp_relay] test dhcp6relay in LLA missing
5 participants