-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic #16494
Merged
yxieca
merged 2 commits into
sonic-net:master
from
yaqiangz:azure-master_dhcp6relay_lla
Jan 14, 2025
Merged
[dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic #16494
yxieca
merged 2 commits into
sonic-net:master
from
yaqiangz:azure-master_dhcp6relay_lla
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
azure-master_dhcp6relay_lla
branch
from
January 13, 2025 09:49
c435f64
to
c2b5829
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
added
Request for 202405 branch
Request for 202411 branch
and removed
Request for 202405 branch
Request for 202411 branch
labels
Jan 14, 2025
yxieca
approved these changes
Jan 14, 2025
Hi @bingwang-ms could you please help to approve this backport request? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 16, 2025
…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
Cherry-pick PR to 202405: #16554 |
12 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 16, 2025
…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
Cherry-pick PR to 202411: #16556 |
12 tasks
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…ogic (sonic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
mssonicbld
pushed a commit
that referenced
this pull request
Jan 17, 2025
…6494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Jan 17, 2025
bingwang-ms
pushed a commit
that referenced
this pull request
Jan 17, 2025
…ogic (#16494) (#16567) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
yaqiangz
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Jan 21, 2025
Backport for 202405: #16567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16344
Type of change
Back port request
Approach
What is the motivation for this PR?
We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing
How did you do it?
Modify
test_interface_binding
:How did you verify/test it?
Run test_dhcpv6_relay.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation