Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy] Upgrade test server docker SDK client version to 7.1.0 #16593

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

wangxin
Copy link
Collaborator

@wangxin wangxin commented Jan 20, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Previously the upgrade of requests package caused a compatibility issue with the docker SDK client. A workaround was introduced in the playbook to force install a lower version requests package.

After the issue was fixed in the docker SDK client side, the workaround code can be removed.

How did you do it?

This change removed the workaround code and upgraded the docker client to version 7.1.0.

How did you verify/test it?

Tested add/remove topo using the testbed-cli.sh

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Previously the upgrade of requests package caused a compatibility issue with the docker SDK client.
A workaround was introduced in the playbook to force install a lower version requests package.

After the  issue was fixed in the docker SDK client side, the workaround code can be removed.

This change removed the workaround code and upgraded the docker client to version 7.1.0.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 3d850a7 into sonic-net:master Jan 22, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants