[Log Analyzer] Update the log analyzer init flow #16610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we have the rsyslog rate limit, there could be wrong loganalyzer failures in the below scenario: 1. log analyzer is disabled in test A, and it produces a lot of syslogs including errors, which is expected. 2. The errors are suppressed due to the log rate limit. 3. Test B starts with loganalyzer, and the errors are printed to syslog during test B. 4. Log analyzer reports the errors which should be ignored in test A. We should flush the rsyslog before the log analyzer adds start marker. Change-Id: I54b2923589926a9bef9ea696f7384108fd461e61
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16610 in repo sonic-net/sonic-mgmt |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Because we have the rsyslog rate limit, there could be wrong loganalyzer failures in the below scenario:
We should flush the rsyslog before the log analyzer adds start marker.
Type of change
Back port request
Approach
What is the motivation for this PR?
See the summary.
How did you do it?
See the summary.
How did you verify/test it?
Run regression with the change, issue not reproduced, no side effects observed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation