Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash] Improve dash test cases #16612

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimmyzhai
Copy link
Contributor

Description of PR

Summary:
Enhance vnet test cases to pass on kvm sonic dpu with the use of DASH API update.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

The test cases are failing towards the latest dash pipeline on kvm dpu.

How did you do it?

  • Update basic config template for calling DASH API correctly, specially using API ENI_ROUTE to assign routing group to eni.
  • Apply gnmi file with max update - 1 in single command, which avoids dash object dependency in dash orch.
  • Ignore underlay src/dst ether mac and ip ttl in packet verification

How did you verify/test it?

./run_tests.sh -u -n vms-kvm-dpu -d vlab-01 -m individual -e --skip_sanity -e --disable_loganalyzer -c dash/test_dash_vnet.py -f vtestbed.yaml -i ../ansible/veos_vtb

dash/test_dash_vnet.py::test_outbound_vnet[udp-no-underlay-route] PASSED                                                                                                                                             [  3%]
dash/test_dash_vnet.py::test_outbound_vnet[udp-with-underlay-route] PASSED                                                                                                                                           [  6%]
dash/test_dash_vnet.py::test_outbound_vnet[tcp-no-underlay-route] PASSED                                                                                                                                             [  9%]
dash/test_dash_vnet.py::test_outbound_vnet[tcp-with-underlay-route] PASSED                                                                                                                                           [ 12%]
dash/test_dash_vnet.py::test_outbound_vnet[echo_request-no-underlay-route] PASSED                                                                                                                                    [ 15%]
dash/test_dash_vnet.py::test_outbound_vnet[echo_request-with-underlay-route] PASSED                                                                                                                                  [ 18%]
dash/test_dash_vnet.py::test_outbound_vnet[echo_reply-no-underlay-route] PASSED                                                                                                                                      [ 21%]
dash/test_dash_vnet.py::test_outbound_vnet[echo_reply-with-underlay-route] PASSED                                                                                                                                    [ 25%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[udp-no-underlay-route] PASSED                                                                                                                                      [ 28%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[udp-with-underlay-route] PASSED                                                                                                                                    [ 31%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[tcp-no-underlay-route] PASSED                                                                                                                                      [ 34%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[tcp-with-underlay-route] PASSED                                                                                                                                    [ 37%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[echo_request-no-underlay-route] PASSED                                                                                                                             [ 40%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[echo_request-with-underlay-route] PASSED                                                                                                                           [ 43%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[echo_reply-no-underlay-route] PASSED                                                                                                                               [ 46%]
dash/test_dash_vnet.py::test_outbound_vnet_direct[echo_reply-with-underlay-route] PASSED                                                                                                                             [ 50%]
dash/test_dash_vnet.py::test_outbound_direct[udp-no-underlay-route] PASSED                                                                                                                                           [ 53%]
dash/test_dash_vnet.py::test_outbound_direct[udp-with-underlay-route] PASSED                                                                                                                                         [ 56%]
dash/test_dash_vnet.py::test_outbound_direct[tcp-no-underlay-route] PASSED                                                                                                                                           [ 59%]
dash/test_dash_vnet.py::test_outbound_direct[tcp-with-underlay-route] PASSED                                                                                                                                         [ 62%]
dash/test_dash_vnet.py::test_outbound_direct[echo_request-no-underlay-route] PASSED                                                                                                                                  [ 65%]
dash/test_dash_vnet.py::test_outbound_direct[echo_request-with-underlay-route] PASSED                                                                                                                                [ 68%]
dash/test_dash_vnet.py::test_outbound_direct[echo_reply-no-underlay-route] PASSED                                                                                                                                    [ 71%]
dash/test_dash_vnet.py::test_outbound_direct[echo_reply-with-underlay-route] PASSED                                                                                                                                  [ 75%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[udp-no-underlay-route] PASSED                                                                                                                                  [ 78%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[udp-with-underlay-route] PASSED                                                                                                                                [ 81%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[tcp-no-underlay-route] PASSED                                                                                                                                  [ 84%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[tcp-with-underlay-route] PASSED                                                                                                                                [ 87%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[echo_request-no-underlay-route] PASSED                                                                                                                         [ 90%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[echo_request-with-underlay-route] PASSED                                                                                                                       [ 93%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[echo_reply-no-underlay-route] PASSED                                                                                                                           [ 96%]
dash/test_dash_vnet.py::test_inbound_vnet_pa_validate[echo_reply-with-underlay-route] PASSED                                                                                                                         [100%]

Any platform specific information?

platform: kvm sonic dpu
topo: vms-kvm-dpu

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
@mssonicbld
Copy link
Collaborator

/azp run

@jimmyzhai jimmyzhai requested a review from Pterosaur January 21, 2025 12:26
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai jimmyzhai requested a review from r12f January 23, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants