Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecmp] Skip warm-reboot tests on dualtor #16643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jan 23, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Dualtor doesn't support warm reboot, so the warm reboot tests in test_ecmp_hash_seed_value will leave the DUT dataplane in an inconsistent state. Let's skip them.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

As the motivation.

How did you verify/test it?

Run on dualtor.

ecmp/test_ecmp_sai_value.py::test_ecmp_hash_seed_value[str2-7050cx3-acs-09-common] PASSED                                                                                                                                                                              [ 10%]
ecmp/test_ecmp_sai_value.py::test_ecmp_hash_seed_value[str2-7050cx3-acs-09-restart_syncd] PASSED                                                                                                                                                                       [ 20%]
ecmp/test_ecmp_sai_value.py::test_ecmp_hash_seed_value[str2-7050cx3-acs-09-reload] PASSED                                                                                                                                                                              [ 30%]
ecmp/test_ecmp_sai_value.py::test_ecmp_hash_seed_value[str2-7050cx3-acs-09-reboot] PASSED                                                                                                                                                                              [ 40%]
ecmp/test_ecmp_sai_value.py::test_ecmp_hash_seed_value[str2-7050cx3-acs-09-warm-reboot] SKIPPED (Skip warm reboot test on dualtor topology)                                                                                                                            [ 50%]
ecmp/test_ecmp_sai_value.py::test_ecmp_offset_value[str2-7050cx3-acs-09-common] PASSED                                                                                                                                                                                 [ 60%]
ecmp/test_ecmp_sai_value.py::test_ecmp_offset_value[str2-7050cx3-acs-09-restart_syncd] PASSED                                                                                                                                                                          [ 70%]
ecmp/test_ecmp_sai_value.py::test_ecmp_offset_value[str2-7050cx3-acs-09-reload] PASSED                                                                                                                                                                                 [ 80%]
ecmp/test_ecmp_sai_value.py::test_ecmp_offset_value[str2-7050cx3-acs-09-reboot] PASSED                                                                                                                                                                                 [ 90%]
ecmp/test_ecmp_sai_value.py::test_ecmp_offset_value[str2-7050cx3-acs-09-warm-reboot] SKIPPED (Skip warm reboot test on dualtor topology)                                                                                                                               [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/ecmp/test_ecmp_sai_value.py:206

  • The variable 'parameter' is used but not defined in the provided diff. Ensure 'parameter' is defined and has the correct value before this check.
not (parameter == "warm-reboot" and "dualtor" in tbinfo["topo"]["name"]),
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu force-pushed the ecmp_wb_skip_dualtor branch from 132b499 to e2198eb Compare January 23, 2025 03:53
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants