-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sanity-check] Add IPv4 MGMT reachability check #16645
Merged
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 7862419.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Blueve
approved these changes
Jan 23, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 23, 2025
Summary: Recently, we observed some DUT lost IPv4 MGMT reachability. However, since it's still IPv6 MGMT reachable, the issue is hard to be noticed. To catch such issue, this PR introduces IPv4 MGMT sanity check. If the device has IPv4 MGMT IP assigned but it's unreachable, then sanity_check will fail the testcase. What is the motivation for this PR? Recently, we observed some DUT lost IPv4 MGMT reachability. However, since it's still IPv6 MGMT reachable, the issue is hard to be noticed. How did you do it? To catch such issue, this PR introduces IPv4 MGMT sanity check. If the device has IPv4 MGMT IP assigned but it's unreachable, then sanity_check will fail the testcase. How did you verify/test it? Verified by run test_bgp_fact with sanity_check.
Cherry-pick PR to 202411: #16649 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Recently, we observed some DUT lost IPv4 MGMT reachability. However, since it's still IPv6 MGMT reachable, the issue is hard to be noticed.
To catch such issue, this PR introduces IPv4 MGMT sanity check. If the device has IPv4 MGMT IP assigned but it's unreachable, then sanity_check will fail the testcase.
Type of change
Back port request
Approach
What is the motivation for this PR?
Recently, we observed some DUT lost IPv4 MGMT reachability. However, since it's still IPv6 MGMT reachable, the issue is hard to be noticed.
How did you do it?
To catch such issue, this PR introduces IPv4 MGMT sanity check. If the device has IPv4 MGMT IP assigned but it's unreachable, then sanity_check will fail the testcase.
How did you verify/test it?
Verified by run
test_bgp_fact
with sanity_check.When DUT IPv4 MGMT is reachable, sanity_check will pass and we can see below logs:
If manually remove the DUT IPv4 MGMT address from eth0, then sanity_check fails with below error logs:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation