SRv6: add dscp_mode configuration for MySID entry #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a sync with CONFIG_DB to store MySID entry dscp mode * create a tunnel/tunnel term entry for uDT46 MySID entry (the tunnel is reused for the same dscp_mode) * add a new vs test Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
previously approved these changes
Dec 26, 2024
Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
reviewed
Jan 6, 2025
| } | ||
|
|
||
| bool Srv6Orch::getMySidEntryDscpMode(const string& my_sid, sai_tunnel_dscp_mode_t& dscp_mode) | ||
| { |
There was a problem hiding this comment.
this function need to be adjusted to adapt to the latest changes in CONFIG_DB schema
There was a problem hiding this comment.
done in the 5477a16
BYGX-wcr
reviewed
Jan 6, 2025
| self.cdb.create_entry("SRV6_MY_SIDS", "fe00:0:2:ff05::", {"dscp_mode": "pipe"}) | ||
|
|
||
| # Create MySID entry with dscp_mode uniform | ||
| dvs.runcmd("vtysh -c \"configure terminal\" -c \"segment-routing\" -c \"srv6\" -c \"locators\" -c \"locator loc1\" -c \"prefix fc00:0:2::/48 block-len 32 node-len 16 func-bits 16\" -c \"behavior usid\"") |
There was a problem hiding this comment.
why do we need to add both FRR config and Linux Kernel Table config here?
There was a problem hiding this comment.
this is how all the SRv6 vstests are done now, the new test is aligned to use the same approach
* align with the latest MySID config db schema * use reverse locator lookup to derive the locator in case of ambiguity Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
reviewed
Jan 8, 2025
| auto blen = fvsGetValue(fvs, "block_len", true); | ||
| auto nlen = fvsGetValue(fvs, "node_len", true); | ||
| auto flen = fvsGetValue(fvs, "func_len", true); | ||
| auto alen = fvsGetValue(fvs, "arg_len", true); |
There was a problem hiding this comment.
those fields are optional and have default values in CONFIG_DB|SRV6_MY_LOCATORS
There was a problem hiding this comment.
fixed in the a5cd890
Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for the "dscp_mode" MySID entry configuration:
Why I did it
To support "dscp_mode" MySID entry configuration
How I verified it
New vstest
test_Srv6MySidUDT46TunnelDscpModeDetails if related