Unify intent selector, model selector, and agentic chat dropdown #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyang
force-pushed
the
bl/unify-intent-model-selector
branch
from
527e09f to
2d34d03
Compare
beyang
force-pushed
the
bl/unify-intent-model-selector
branch
from
2757dbe to
2e656dc
Compare
beyang
force-pushed
the
bl/unify-intent-model-selector
branch
from
461c851 to
7937fee
Compare
beyang
changed the title
aramaraju
reviewed
Jan 19, 2025
Comment on lines
+50
to
+51
| .aiderignore | ||
| .aider.* |
abeatrix
reviewed
Jan 20, 2025
| map(([enableToolCody, models]) => { | ||
| const handlers: OmniboxHandlerOption[] = [] | ||
| handlers.push(OmniboxHandlers.Auto) | ||
| handlers.push(OmniboxHandlers.DeepCody) |
There was a problem hiding this comment.
Do we still need to check if they have the feature flags for agentic chat and terminal access before we add the handler?
| ([hasEarlyAccess, isDeepCodyEnabled, defaultToHaiku]) => { | ||
| ([ | ||
| hasEarlyAccess, | ||
| isDeepCodyEnabled, |
There was a problem hiding this comment.
We need to add back agentic chat to the model list here?
| @@ -85,7 +84,7 @@ class ToolFactory { | |||
| public getInstances(): CodyTool[] { | |||
| // Create fresh instances of all registered tools | |||
| return Array.from(this.tools.entries()) | |||
| .filter(([name]) => name !== 'CliTool' || toolboxManager.getSettings()?.shell?.enabled) | |||
| .filter(([name]) => name !== 'CliTool') | |||
There was a problem hiding this comment.
This should check the feature flags value for agentic chat terminal access, and if the client supports terminal access, before we filter the cli tool.
abeatrix
reviewed
Jan 20, 2025
| const { model } = handler | ||
| if (!model) { | ||
| if (handler.id === OmniboxHandlers.DeepCody.id) { | ||
| return 'An agent powered by Claude 3.5 Sonnet (New) and other models with tool-use capabilities to gather contextual information for better responses.' |
There was a problem hiding this comment.
Suggested change
| return 'An agent powered by Claude 3.5 Sonnet (New) and other models with tool-use capabilities to gather contextual information for better responses.' | |
| return 'An agent powered by Claude 3.5 Haiku with tool-use capabilities to gather contextual information for better responses.' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Later
Test plan