Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small CSS and icons fixes #6766

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small CSS and icons fixes #6766

wants to merge 2 commits into from
+5 −8

Conversation

rrhyne
Copy link
Contributor

@rrhyne rrhyne commented Jan 23, 2025 •
edited
Loading

Fixes missing drop shadow on intent dropdown padding issue, and replaces one last 'sparkles' for the chosen agentic 'brain' icon.

Before
Screenshot 2025-01-22 at 3 28 21 PM

After
image

Test plan

  • manually review the icons are corrected from sparkles to brain for agentic behavior
  • manually ensure the intent dropdown has a shadow
  • manually ensure rolling over an item in the intent dropdown doesn't cause text to show as dark grey on primary blue

@rrhyne rrhyne requested review from taiyab, dominiccooney and thenamankumar and removed request for dominiccooney January 23, 2025 00:18
@taiyab
Copy link
Contributor

taiyab commented Jan 23, 2025 •
edited
Loading

@rrhyne Shadows on the menu were added in: #6757

Could you review that just to make sure I didn't make a mistake there? And if it's there, should we revert that change here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiyab taiyab Awaiting requested review from taiyab

@thenamankumar thenamankumar Awaiting requested review from thenamankumar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrhyne @taiyab