Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

more idiomatic Ubuntu install instructions #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sqs
Copy link
Member

@sqs sqs commented Feb 26, 2020

Installing nodejs and npm via apt is fairly rare for developers in my experience. They usually prefer to use something like nvm instead of installing each npm module as a separate deb package.

Installing `nodejs` and `npm` via `apt` is fairly rare for developers in my experience. They usually prefer to use something like nvm instead of installing each npm module as a separate deb package.
@sqs sqs requested a review from creachadair as a code owner February 26, 2020 05:28
npm i -g yarn
```
1. `apt install clang libclang-dev llvm`
1. Install Node.js (if it's not already installed): `apt install nodejs npm`
Copy link

@creachadair creachadair Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly confused: The PR description says it's not idiomatic to install nodejs and npm via apt, but that's still what we're doing here, right? Did you mean "install yarn via npm" instead?

Separately, a minor nit: I realize markdown processors will render the text with sequential numbers, but part of the point of Markdown is it should be human-readable even in plain text form. I personally dislike the style of using "1." for every bullet, especially when there are only a few. YMMV.

I'd argue the code fence was preferable, because it was copy-pasteable into the terminal. What do you think about something like:

apt install clang libclang-dev llvm
if ! which node ; then apt install nodejs npm ; end

Having a naked pointer to a long page of mixed-system install instructions seems like a regression to me, and if I read it right you may have to click through to at least one additional page (if your Ubuntu is old enough). Maybe we can just inline the hot path here?

curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
sudo apt update && sudo apt install yarn

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants