Support serving bare repositories #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Looks good to me, but I'll defer ultimate approval to @keegancsmith.
Thanks so much for the PR :)
mrnugget
reviewed
Nov 1, 2021
This should be more robus than the previous check where we only checked for the presence of a .git folder.
We do already check each candidate if it is a folder before calling the git related functions.
|
Rebased and addressed the latest review comments. |
keegancsmith
approved these changes
Nov 19, 2021
| @@ -32,7 +32,7 @@ func TestReposHandler(t *testing.T) { | |||
| repos: []string{"project1", "project2"}, | |||
| }, { | |||
| name: "nested", | |||
| repos: []string{"project1", "project1/subproject", "project2", "dir/project3"}, | |||
| repos: []string{"project1", "project1/subproject", "project2", "dir/project3", "dir/project4.bare"}, | |||
There was a problem hiding this comment.
This doesn't seem like a hack at all, succinct. So I actually like it :) FYI I think there is a more traditional way to indicate a repo is base, and that is if the name has the suffix .git. I believe git used to check the suffix to decide, but it has a more robust check these days based on actual presence of git files.
There was a problem hiding this comment.
Oh yeah, The repos actually end up with .git in my deployment. I just felt like being explicit there.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This allows bare repos in addition to worktree style git repos in detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to my own issue (#634) where I was asking for support for serving bare repositories from a directory.
This PR has a couple of changes. Some of them can be seen as a refactoring of sorts. The comments in the original implementation were a bit misleading as they appeared to be the other way around (compared to what the tests wanted). I took the liberty to rewrite them a bit. All of the original tests still pass. I've added one case where a bare repository is created (by suffixing the name of a repo with
.bare) which seems to work. I am not happy about the repository name suffix hack that I had to add but it also doesn't seem like it is worth the effort to refactor the entire test machinery just because of this.I am open for feedback on this.
cc @mrnugget & @keegancsmith who where very responsive to my issue