-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batches: fail earlier on dotcom #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending we don't change the count thingy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog entry, but otherwise LGTM modulo the things Erik also said.
Omg I'm so out of practice with CHANGELOG because we never log anything for SSBC since it's all experimental. 😂 Thanks for the reminder, Adam. |
This PR is in response to https://github.com/sourcegraph/sourcegraph/issues/28252 and does two things:
Lessens the arbitrarily large default count applied to the batch specDecided not to proceed with this change since we haven't heard of actual enterprise customers running into timeouts yet and this is expected to become a non-issue once we actually userepositoriesMatchingQuery
from 999999 to 99999, which is less likely to cause timeouts.count: all
.src preview|apply
will fail right away on the first thing it does, which is the version check, as opposed to much later after execution finishes and we go to upload changesets: