Deferred lookups of public and private keys #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f public and private key values. Minimum requirement of Puppet 6
baurmatt
reviewed
Jan 26, 2020
| Integer[1,65535] $listen_port, | ||
| Enum['present','absent'] $ensure = 'present', | ||
| Variant[Array,String] $address, | ||
| Variant[String, Deferred] $private_key, |
There was a problem hiding this comment.
This would drop support for all Puppet version > 6 because the Type "Deferred" isn't known by Puppet 4/5.
I've implemented this without knowing someone else already did it. I think I found solution which supports Puppet 4/5/6.
bastelfreak
added a commit
to bastelfreak/puppet-wireguard
that referenced
this pull request
Jul 26, 2021
switch from camptocamp/systemd to voxpupuli/systemd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deferred lookups of public and private key values using the new Puppet 6.x deferred functions. This allows these values to be looked up by the agent from a secrets store (eg: Hashicorp Vault).
This current implementation bumps the minimum required Puppet version up to 6.x to support deferred functions, but perhaps somebody with more Puppet experience can change this.