Skip to content

Commit

Permalink
refs platform/#3202: better changelog and lint suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Stevesibilia committed Oct 17, 2024
1 parent 7b914b4 commit b458e4b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,24 @@ Following semver, any non backwards compatible feature implies that the next rel

[Compare with previous version](https://github.com/sparkfabrik/terraform-google-gcp-artifact-registry/compare/0.7.0...0.7.1)

### Changed

- FIX: use the value of `username_password_credentials_password_secret_version` instead of data output to keep `latest` as version for secret.

## [0.7.0] - 2024-10-15

[Compare with previous version](https://github.com/sparkfabrik/terraform-google-gcp-artifact-registry/compare/0.6.0...0.7.0)

### Added

- BREAKING: add support for GCP secret as password for remote repositories. Break backwards compatibility if using `username_password_credentials_password_secret_version` as it now stores the secret version (not the name).

## [0.6.0] - 2024-10-09

[Compare with previous version](https://github.com/sparkfabrik/terraform-google-gcp-artifact-registry/compare/0.5.0...0.6.0)

### Added

- FEATURE: add support for mirror public registry (Docker Hub) if `custom_repository_uri` is `DOCKER_HUB`

## [0.5.0] - 2024-08-29
Expand Down
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ resource "google_artifact_registry_repository" "repositories" {
content {
username_password_credentials {
username = upstream_credentials.value.username_password_credentials_username
password_secret_version = "projects/${var.project_id}/secrets/${upstream_credentials.value.username_password_credentials_password_secret_name}/versions/${upstream_credentials.value.username_password_credentials_password_secret_version}"
password_secret_version = "projects/${var.project_id}/secrets/${google_secret_manager_secret_version.remote_repository_secrets[each.key].secret}/versions/${upstream_credentials.value.username_password_credentials_password_secret_version}"
}
}
}
Expand Down

0 comments on commit b458e4b

Please sign in to comment.