Refs platform/#3202

[Stevesibilia]

PR Type

Enhancement

---

Description

• Simplified remote repository configuration by removing unnecessary local variables and data sources
• Added google_project data source to fetch project number
• Updated password_secret_version in upstream_credentials block to use project number and secret details directly
• Removed hardcoded "latest" version for password secret, allowing for more flexible version management
• Improved code efficiency and readability by removing redundant data processing

---

Changes walkthrough 📝

	Relevant files
Enhancement	main.tf Refactor remote repository configuration                                  main.tf Removed remote_repositories local variable Removed google_secret_manager_secret_version data source Added google_project data source Updated password_secret_version in upstream_credentials block +3/-19

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Potential Error The password_secret_version in the upstream_credentials block is now constructed using data.google_project.project.number, but this data source is not used anywhere else. Ensure that this data source is properly initialized and available. Code Removal The PR removes the remote_repositories local variable and the google_secret_manager_secret_version data source. Verify that this removal doesn't break any other parts of the code that might have depended on these.

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Simplify complex string construction by using a local variable The password_secret_version reference might be too verbose. Consider creating a local variable to construct this string, which can improve readability and maintainability. main.tf [121] -password_secret_version = "projects/${data.google_project.project.number}/secrets/${upstream_credentials.value.username_password_credentials_password_secret_name}/versions/${upstream_credentials.value.username_password_credentials_password_secret_version}" +password_secret_version = local.password_secret_version_path Suggestion importance[1-10]: 7 Why: This suggestion improves code readability and maintainability, which is important for long-term project health.	7
Performance	Use a more specific data source to fetch only the required project information Consider using a data source to fetch the project number instead of creating a new data block for the entire project. This can be more efficient and focused on the specific information needed. main.tf [38-40] -data "google_project" "project" { +data "google_project_number" "current" { project_id = var.project_id } Suggestion importance[1-10]: 5 Why: The suggestion is valid and can improve code efficiency, but the current implementation is not incorrect or harmful.	5

[Monska85]

LGTM 👍