Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with soft-deleted causers #643

Closed
wants to merge 4 commits into from

Conversation

EthicalJobsJesse
Copy link

At the moment if a causer is soft-deleted you can't see there records. Adding this config allows you to resolve soft-deleted causers as well

@Gummibeer
Copy link
Collaborator

Hey,
thanks for this PR. But the test cases for this change are missing.
And in #456 we've already discussed some issues with the most common implementations. The last comment by @LeonAlvarez looks promising. Haven't tested it but could be that removing the scope in a whole could prevent conflicts if the relationship returns a mix of soft deletable and normal models.

At the end I won't merge an implementation that doesn't work with the whole morphable relationship.

Copy link
Collaborator

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR doesn't contain unittests that prove that the implementation works with mixed relationships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants