Change style options and a new setting for intializing #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move javascript inline CSS into CSS file Add marker.style option Add directInitialize setting
spchuang
requested changes
May 4, 2017
|
|
||
| video.markers({ | ||
| markerStyle: { | ||
| 'width':'8px', | ||
| 'background-color': 'red' |
There was a problem hiding this comment.
I'm inclined to not make this change since it is a big breaking change to the API. Moving markerStyle to markerTip.style isn't appropriate either because markerTip is used for the hover-over pointer thing.
|
@nyroDev sorry for the late reply. Just took a look and commented at the code change. |
spchuang
reviewed
May 4, 2017
| }, | ||
| markers: [ | ||
| {time: 9.5, text: "this"}, | ||
| {time: 16, text: "is"}, | ||
| {time: 16, text: "is", style: {'background-color': 'yellow'}}, |
There was a problem hiding this comment.
Just took another look. Currently, we offer the ability to append class to marker object like {time: 9.5, text: "this", overlayText: "1", class: "special-blue"}, which achieves the same thing as passing a style object.
Is there a scenario where you can't pass in a class name and need hardcoded style?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the doc as far as I can see, but some elements still need to be done:
Hope this will help.