Better options for serializer #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #180 +/- ##
===========================================
+ Coverage 53.90% 66.42% +12.51%
===========================================
Files 231 249 +18
Lines 9337 10042 +705
Branches 1071 1076 +5
===========================================
+ Hits 5033 6670 +1637
+ Misses 4049 3020 -1029
- Partials 255 352 +97 ☔ View full report in Codecov by Sentry. |
JR-Morgan
previously approved these changes
Nov 29, 2024
| ) : IDeserializeProcess | ||
| { | ||
| private DeserializeOptions _options = new(false); | ||
| private readonly DeserializeProcessOptions _options = options ?? new(false); | ||
|
|
||
| private readonly ConcurrentDictionary<string, (string, IReadOnlyList<string>)> _closures = new(); | ||
| private readonly ConcurrentDictionary<string, Base> _baseCache = new(); |
There was a problem hiding this comment.
We should not need to optimise for cases where we have a single c# instance of Base appear multiple times in the graph
JR-Morgan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to use reduce a list allocation
also adds option to cache by Base. Could be unnecessary for IFCs