Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite pooling for connections and commands #193

Merged
merged 33 commits into from
Jan 8, 2025
Merged

Sqlite pooling for connections and commands #193

merged 33 commits into from
Jan 8, 2025

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Dec 20, 2024

Adds a pool for sqlite connections and commands to reduce creations. Dispose is needed for the pool.

Requires #194

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 22 lines in your changes missing coverage. Please review.

Project coverage is 68.08%. Comparing base (11fe8e8) to head (5646766).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/Speckle.Sdk/Credentials/AccountManager.cs 28.57% 5 Missing ⚠️
src/Speckle.Sdk/SQLite/CacheDbCommandPool.cs 94.64% 2 Missing and 1 partial ⚠️
src/Speckle.Sdk/Serialisation/V2/Send/BaseItem.cs 40.00% 3 Missing ⚠️
...k/Serialisation/V2/DummySendServerObjectManager.cs 0.00% 2 Missing ⚠️
...le.Sdk/Serialisation/V2/SerializeProcessFactory.cs 50.00% 2 Missing ⚠️
...peckle.Sdk/SQLite/SqLiteJsonCacheManagerFactory.cs 66.66% 1 Missing ⚠️
...Sdk/Serialisation/V2/ServerObjectManagerFactory.cs 50.00% 1 Missing ⚠️
...s/Speckle.Sdk.Serialization.Tests/DetachedTests.cs 50.00% 1 Missing ⚠️
...k.Serialization.Tests/DummySqLiteReceiveManager.cs 50.00% 1 Missing ⚠️
....Sdk.Serialization.Tests/DummySqLiteSendManager.cs 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #193       +/-   ##
===========================================
+ Coverage   55.12%   68.08%   +12.96%     
===========================================
  Files         239      260       +21     
  Lines        9730    10526      +796     
  Branches     1076     1087       +11     
===========================================
+ Hits         5364     7167     +1803     
+ Misses       4113     3011     -1102     
- Partials      253      348       +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan
Copy link
Member

LGTM, but I want to bench mark these changes

@JR-Morgan JR-Morgan self-requested a review January 8, 2025 10:58
@adamhathcock adamhathcock merged commit ed5bdc9 into dev Jan 8, 2025
4 checks passed
@adamhathcock adamhathcock deleted the sqlite-pools branch January 8, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants