Fixed path bug with links in SVG inheritance diagrams #10576
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fixes links in SVG inheritance diagrams when those diagrams are in documents not at the base level
Feature or Bugfix
Purpose
Currently, links in SVG inheritance diagrams only work when the documents are at the base level. That's because the URIs supplied to the diagram are relative to the document (as is appropriate for PNG output), but the SVGs live in the
/_images
folder, so the URIs need to be relative to that location. There is a hard-coded'../'
that gets prepended to the URIs, which fixes only base-level documents. Documents in sub-directories result in SVG links that have one or more extraneous'../'
that break the links.Detail
This PR fixes the URIs to be relative to the image directory prior to making the SVG inheritance diagrams.
Relates
Fixes #10570