Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trend micro vision one v3: feature update - Added action to submit item from Splunk vault to XDR portal for sandbox analysis. #20

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Trend micro vision one v3: feature update - Added action to submit item from Splunk vault to XDR portal for sandbox analysis. #20

merged 14 commits into from
Oct 22, 2024

Conversation

shaqnawe
Copy link
Contributor

@shaqnawe shaqnawe commented Sep 30, 2024 •
edited
Loading

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 23 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit a3a2c95 - https://drive.google.com/file/d/1CJNXukurP8-OQj8N0hG_hwhWs6H_Stst/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit a3a2c95 - https://drive.google.com/file/d/1nS_I_8WG61vQ1JHpkEBtyOPXI1OecdAN/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit 76593ec - https://drive.google.com/file/d/1C8AJ1u5Da5kUKNWr8yx8bnOtApLWL-_2/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit 76593ec - https://drive.google.com/file/d/1erNECGmHykbVHgV6TiuN0hsWkdSTcKZm/view?usp=drivesdk

@shaqnawe
Copy link
Contributor Author

Please advise how do I resolve "FAILED - file_manipulation_functions: File manipulation functions exist". Thank you.

@shaqnawe shaqnawe changed the title Trend micro vision one v3 Trend micro vision one v3: feature update - Added action to submit item from Splunk vault to XDR portal for sandbox analysis. Oct 1, 2024
@ishans-crest
Copy link
Contributor

Please advise how do I resolve "FAILED - file_manipulation_functions: File manipulation functions exist". Thank you.

We will fix this issue from our end.

@shaqnawe
Copy link
Contributor Author

shaqnawe commented Oct 1, 2024

Please advise how do I resolve "FAILED - file_manipulation_functions: File manipulation functions exist". Thank you.

We will fix this issue from our end.

Thank you!

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Static Tests results for commit e0b3b73 - https://drive.google.com/file/d/1y6NAJZ_X_iuJl5qKJeZ0-0043Ukq080x/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Compile Tests results for commit e0b3b73 - https://drive.google.com/file/d/1FEMGxlYfcczSh8UihbmKThtTeRyipTpB/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Static Tests results for commit 106d1a0 - https://drive.google.com/file/d/1HvH3iTa4TWZ1bhTXXbY8ATeXyOULPHrW/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Compile Tests results for commit 106d1a0 - https://drive.google.com/file/d/1bdSrcZSNKNRtaHTKzm7jeC127DQm6N0T/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Static Tests results for commit 106d1a0 - https://drive.google.com/file/d/1Fpu0blIQv57P0IZ_yeIWr-DWo5ZTCTCr/view?usp=drivesdk

@shaqnawe
Copy link
Contributor Author

shaqnawe commented Oct 7, 2024

@ishans-crest Any updates on this?

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit d30aede - https://drive.google.com/file/d/1ZjBqMCpAv98QzKLFIayjkjzyi5C3IKEa/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit d30aede - https://drive.google.com/file/d/1fM5Dp3aieZ9xD3ZrfSCiCHrIOHhOrjAk/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit 9bd6092 - https://drive.google.com/file/d/1ZMdpSGYUSy-DLRSCgzCciio1RCUxzwd7/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit 9bd6092 - https://drive.google.com/file/d/1m124GbQKngatL6RaNX6AHUJLCSxEATCA/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit 5e80b68 - https://drive.google.com/file/d/1PGxFo1MWfYxoobOemIgbfNLF9LG8bXNk/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit 5e80b68 - https://drive.google.com/file/d/1wcoI1HhhVL9P4hKXEdxvWQaPRHk3vJNO/view?usp=drivesdk

@shaqnawe
Copy link
Contributor Author

@ishans-crest Anything needed on my end on this?

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit 5e80b68 - https://drive.google.com/file/d/1UKAUYFpOEiJdJ_AEXSEA4zv9dCp24uXT/view?usp=drivesdk

@stutib-crest
Copy link

@ishans-crest Anything needed on my end on this?

Hi @shaqnawe ,
We have resolved the pipeline failures for "FAILED - file_manipulation_functions: File manipulation functions exist".

@shaqnawe
Copy link
Contributor Author

@ishans-crest Anything needed on my end on this?

Hi @shaqnawe , We have resolved the pipeline failures for "FAILED - file_manipulation_functions: File manipulation functions exist".

Thank you!

@shaqnawe
Copy link
Contributor Author

@ishans-crest Is the code merge complete? I have a client waiting for the update, please advise.

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Static Tests results for commit 2963b5f - https://drive.google.com/file/d/10DrM8Q6I0sXys3sl5zGE38phQ2XjUCgc/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Compile Tests results for commit 2963b5f - https://drive.google.com/file/d/1B56MiIuFpzbV0BbmS6AsHOOaH8EY7ean/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Static Tests results for commit 631afb2 - https://drive.google.com/file/d/1-B10UFLoTVWcHCNKWDYPrVOk3m0ndfyH/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@ishans-crest Compile Tests results for commit 631afb2 - https://drive.google.com/file/d/1cVJUtXV_u12r2TYCMTEnibpr6yJ2eOgy/view?usp=drivesdk

@ishans-crest
Copy link
Contributor

Yes we have fixed issue with pipeline. You can proceed with merging the code.

@shaqnawe
Copy link
Contributor Author

Min phantom version has been updated to 6.2.2.

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Static Tests results for commit 113ad0d - https://drive.google.com/file/d/1nEa-TeQ-DUzUvKnNbEfyACKL89szcz6u/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@shaqnawe Compile Tests results for commit 113ad0d - https://drive.google.com/file/d/16uDyH5UxUXauMFWluHmso_UmY9nl1XhU/view?usp=drivesdk

@t0mz06 t0mz06 merged commit 41e1c12 into splunk-soar-connectors:next Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishans-crest ishans-crest ishans-crest approved these changes

@mmomin-crest mmomin-crest mmomin-crest approved these changes

Assignees
No one assigned
Labels
developer-supported external-contributor PAPP-34779
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shaqnawe @splunk-soar-connectors-bot @ishans-crest @stutib-crest @mmomin-crest @t0mz06