Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use latest python for pre-commit #133

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

dvarasani-crest
Copy link
Contributor

@dvarasani-crest dvarasani-crest commented Oct 28, 2024

This PR sets python version to 3.12 for per-commit
Reference: ADDON-75861

@dvarasani-crest dvarasani-crest requested a review from a team as a code owner October 28, 2024 10:43
@@ -33,7 +33,7 @@ permissions:

jobs:
pre-commit:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check if pre-commit required python3.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use latest python (3.12) with the ubuntu-latest

@dvarasani-crest dvarasani-crest changed the title ci: fix ubuntu version to 22.04 ci: use latest python for pre-commit Oct 29, 2024
@dvarasani-crest dvarasani-crest merged commit 887a029 into main Oct 30, 2024
3 checks passed
@dvarasani-crest dvarasani-crest deleted the ci/fix-ubuntu-version branch October 30, 2024 06:24
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants