Improve lookup regex - Step 1 - ESCU 5.0 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different classes
remove confidence, impact, and risk_score from the tags field in prep for integration with the RBA changes PR
before hitting | character which may occur WITHOUT whitespace being present. Ensure that any CSV or MLMODEL file written to the app ends in the appropriate datetime stamp.
outputs with better structure and type annotations in prep for new lookup type
but that does not mean it is correct yet. Outputs must be diffed against prior versions to make sure there are no unintended changes.
for better readability
explicit error when something fails to be written correctly to a conf file. Otherwise, it is hard to find out which specific object caused the failure.
not exist.
josehelps
changed the title
ljstella
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improve the lookup regex. Allow inclusion of a number of different arguments to lookup and introduce validations of the inputlookup and outputlookup commands as well.