Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update regex for custom properties. update docs. #44

Merged

Conversation

greatestusername
Copy link
Contributor

Resolves #39
Addresses #40

  • Adds doc links to the API for source of truth on settings for steps, requests, transactions
  • Addresses docs issue where country was shown as an allowed attribute on locations
  • Fixes regexes for custom properties on checks to include _ and - characters

Before the change?

  • Custom properties would not accept as valid entries with _ or - characters

After the change?

  • Custom properties now accept valid entries with _ or - characters

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

terraform-provider-synthetics-fork 12:57> make testacc                                            
TF_ACC=1 go test $(go list ./... | grep -v 'vendor')  -timeout 120m   | sed '/X-Sf-Token/d'
?       github.com/splunk/terraform-provider-synthetics [no test files]
ok      github.com/splunk/terraform-provider-synthetics/synthetics      38.660s

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just docs and regex validation changes

@greatestusername-splunk greatestusername-splunk merged commit 016cc3f into splunk:main Apr 23, 2024
4 checks passed
@greatestusername-splunk greatestusername-splunk deleted the doc-customprops-fix branch April 23, 2024 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synthetics_create_browser_check_v2 documentation
2 participants