Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collect interactive metrics to browser data source #47

Merged
merged 2 commits into from
May 14, 2024

Conversation

technimad-splunk
Copy link
Contributor

Resolves #46

Before the change?

browser check data source could not be used

After the change?

browser data source works as expected, see line with + collect_interactive_metrics = true below:

  + browserData = {
      + id   = "12654"
      + test = [
          + {
              + active                = false
              + advanced_settings     = [
                  + {
                      + authentication              = []
                      + collect_interactive_metrics = true
                      + cookies                     = []
                      + headers                     = []
                      + host_overrides              = []
                      + user_agent                  = ""
                      + verify_certificates         = true
                    },
                ]
              + business_transactions = []
              + created_at            = "2024-05-08 08:40:22.323 +0000 UTC"
              + custom_properties     = []
              + device                = [
                  + {
                      + id                 = 1
                      + label              = "Default Desktop"
                      + network_connection = [
                          + {
                              + description        = "Unthrottled"
                              + download_bandwidth = 0
                              + latency            = 0
                              + packet_loss        = 0
                              + upload_bandwidth   = 0
                            },
                        ]
                      + user_agent         = "Mozilla/5.0 (X11; Linux x86_64; Splunk Synthetics) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.5845.96 Safari/537.36"
                      + viewport_height    = 768
                      + viewport_width     = 1366
                    },
                ]
              + frequency             = 5
              + id                    = 12654
              + last_run_at           = ""
              + last_run_status       = "pending"
              + location_ids          = [
                  + "aws-eu-central-1",
                  + "aws-eu-central-2",
                  + "aws-eu-south-2",
                  + "aws-eu-west-3",
                ]
              + name                  = "browser test"
              + scheduling_strategy   = "round_robin"
              + transactions          = [
                  + {
                      + name  = "New synthetic transaction"
                      + steps = [
                          + {
                              + action               = ""
                              + duration             = 0
                              + name                 = "New step"
                              + option_selector      = ""
                              + option_selector_type = ""
                              + options              = []
                              + selector             = ""
                              + selector_type        = ""
                              + type                 = "go_to_url"
                              + url                  = "https://show.splunk.com"
                              + value                = ""
                              + variable_name        = ""
                              + wait_for_nav         = false
                            },
                        ]
                    },
                ]
              + type                  = "browser"
              + updated_at            = "2024-05-08 08:40:22.328 +0000 UTC"
            },
        ]
    }

Does this introduce a breaking change?

  • Yes
  • [ X ] No

Copy link

github-actions bot commented May 8, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@technimad-splunk
Copy link
Contributor Author

I have read the Code of Conduct and I hereby accept the Terms

@technimad-splunk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request May 8, 2024
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@greatestusername-splunk greatestusername-splunk merged commit 0628737 into splunk:main May 14, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect interactive metrics not supported on browser check data source
2 participants