This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Fix internal docs links #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been rebased on top of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the links I modified yesterday got broken because I didn't link to
.md, but left the links with no file extension.For example:
Seems like GitBook changes
[Zone record](shipments#zones)to
[Zone record](https://github.com/spree/spree-dev-docs/tree/0628094f68853238d9b13aa3b24d7b1e1b13fca4/internals/shipments/README.md#zones)(a commit pointing to README, but not even that as it points to README in
internals/shipments)This link seems to be converted correctly, but please check:
[Zone record](shipments.md#zones)=>[Zone record](/internals/shipments#zones)I found out that I need to add
.mdfile extension from links on other docs pages that seem to work. For example:https://github.com/spree/spree-dev-docs/edit/master/internals/products.md