Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug where spring.cloud.task.transaction-manager was not working #934

Closed

Conversation

lianej
Copy link
Contributor

@lianej lianej commented Nov 17, 2023

Fixes #831

The bug arises from an incorrect preset ConfigurationPhase in the NoTransactionManagerProperty class.

This class, used in conjunction with @Conditional on a @Bean method, therefore determines the effectiveness of the configuration during the REGISTER_BEAN phase, not the PARSE_CONFIGURATION phase.

@cppwfs
Copy link
Collaborator

cppwfs commented Nov 17, 2023

Thank you for your contribution!
LGTM
I'll add one more test and merge!

@cppwfs
Copy link
Collaborator

cppwfs commented Nov 17, 2023

Squashed Merged.
Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated transaction manager
2 participants