-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong return type when invoking Async-annotated method on interface #33957
base: main
Are you sure you want to change the base?
Fix wrong return type when invoking Async-annotated method on interface #33957
Conversation
Can you please add a unit test that exercise the scenario you've described? |
Hi @snicoll , you need a unit test which cover the fix/changes, or the unit test to reproduce the issue? |
Isn't that the same thing? I'd like that we see the change covered by an actual test that shows the behavior you've described is now working. |
Ok I will add it soon. Thank you |
I added unit test |
The last param of
AsyncExecutionAspectSupport.doSubmit
is a return type, which can be get from theinvocation
. But in case of interface with paramter type like:Return type retuned by
invocation.getMethod().getReturnType()
will beObject
because we invokedoSomething
by the interface, not by the impl.My PR try to fix that