Resolve method-only bounded generics correctly #34086
Conversation
|
@rPraml Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@rPraml Thank you for signing the Contributor License Agreement! |
| @@ -180,7 +180,7 @@ else if (genericType instanceof ParameterizedType parameterizedType) { | |||
| generics[i] = resolvedTypeArgument; | |||
| } | |||
| else { | |||
| generics[i] = ResolvableType.forType(typeArgument); | |||
| generics[i] = ResolvableType.forType(typeArgument).resolveType(); | |||
There was a problem hiding this comment.
as far as I understand the code here, we want to resolve the T of a generic. If the T is not defined by the contextType, (because ist is no class Foo<T extends Bar>) we get to this line.
In my case, the T is bound by the function public <T extends BaseType> List<T> get() and means, that T is at least a BaseType
IMHO the type must be resolved here, so that the following code knows , that the elements in the list are BaseType or subtypes. This is later required for jackson, otherwise we have problems mentioned in this SO post.
rPraml
changed the title
I tried to make a unit test and a possible fix for #33968
Someone who knows more about it than me should take another look at the fix ;)