Add CONNECT constant to HttpMethod #34195
Open
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced outdated references to HTTP 1.1 section links (RFC 2616) with updated references to RFC 9110. The original document has been superseded.
Introduced a new constant CONNECT with reference to RFC 9110. Updated values array and valueOf method.
Modified the values test in HttpMethodTests to include the CONNECT method.
The CONNECT method is not supported by HttpComponentsClientHttpConnector and JdkClientHttpConnector.
The CONNECT http method is primarily used for establishing tunnels and is not relevant for RequestMethod.
spring-projects-issues
added
the
status: waiting-for-triage
Updated initAllowedHttpMethods in WebContentGenerator and RequestMappingInfoHandlerMapping to explicitly exclude the CONNECT method.
Please revert, this is unrelated to your proposal of adding |
This reverts commit 5489d56 as it is unrelated to the addition of CONNECT to HttpMethod.
v-perfilev
force-pushed
the
connnect-httpmethod-support
branch
from
822c6cf to
9a1a181
Compare
|
Hello @snicoll ! Done: the commit with link updates has been reverted as requested.
|
|
Let's see where this PR leads us and we can revisit the other change. The rule (not sure where that comes from) is irrelevant as your commits are going to be squashed if we merge this. |
|
@snicoll
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing issue #34044, I noticed that the HttpMethod class does not include a constant for the HTTP method CONNECT, which was introduced in RFC 7231. This PR adds the CONNECT constant to the HttpMethod class and updates the test class HttpMethodTests.
Changes in other files:
CONNECT method excluded in initAllowedHttpMethods of RequestMappingInfoHandlerMapping and in initAllowHeader of WebContentGenerator.
CONNECT method is not supported by HttpComponentsClientHttpConnector and JdkClientHttpConnector, so ClientHttpConnectorTests was updated to dynamically skip CONNECT for these connectors.
CONNECT method is primarily used for establishing tunnels, so it is not relevant for RequestMethod class and was excluded from RequestMethodTests.
These changes prepare the repository for a follow-up PR addressing issue #34044, where a conditional check will be introduced for WebSocket handshakes: if the HTTP version is HTTP/2 the method must be CONNECT, as specified in RFC 8441, otherwise it should be GET.