Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use HttpMethod and HttpHeaders instead of literal string. #34222

Closed
wants to merge 2 commits into from

Conversation

remeio
Copy link
Contributor

@remeio remeio commented Jan 9, 2025

Just refactor.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 9, 2025
Signed-off-by: Mengqi Xu <2663479778@qq.com>
@remeio remeio force-pushed the refactor_header_name branch from 72318e6 to 5e13385 Compare January 9, 2025 15:51
Signed-off-by: Mengqi Xu <2663479778@qq.com>
@snicoll
Copy link
Member

snicoll commented Jan 9, 2025

Thanks for the PR but the constants are public and therefore we can't remove them as you suggest.

@snicoll snicoll closed this Jan 9, 2025
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants