Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/check xyzquat conversion #2073

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Topic/check xyzquat conversion #2073

merged 2 commits into from
Nov 1, 2023

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Oct 31, 2023

Solve #2072

@jorisv jorisv changed the base branch from master to devel October 31, 2023 14:24
@jorisv jorisv self-assigned this Oct 31, 2023
@jorisv jorisv linked an issue Oct 31, 2023 that may be closed by this pull request
pinocchio.XYZQUATToSE3(np.array([ ]) takes in any size of the array #2072
Closed
nim65s
nim65s previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Maybe we can change a < in !=, but I don't have a strong opinion on it

bindings/python/utils/conversions.cpp Outdated Show resolved Hide resolved
@jcarpent jcarpent merged commit be55be6 into devel Nov 1, 2023
20 of 23 checks passed
@jcarpent jcarpent mentioned this pull request Nov 1, 2023
Closed
@jorisv jorisv deleted the topic/check_xyzquat_conversion branch November 8, 2023 15:19
nim65s added a commit to nim65s/robotpkg that referenced this pull request Dec 1, 2023
@nim65s
[math/{py-,}pinocchio] Update to v2.6.21
021794f 
    ## [2.6.21] - 2023-11-27

    ### Added

    - Add inverse dynamics (`rnea`) Python and C++ example ([2083](stack-of-tasks/pinocchio#2083))
    - Add visualization of Frames in MeshCat viewer ([2098](stack-of-tasks/pinocchio#2098))

    ### Fixed

    - Re-initialize `Ycrb[0]` in `crbaMinimal` ([2040](stack-of-tasks/pinocchio#2040))
    - Fix custom scalar use in `log` function ([2047](stack-of-tasks/pinocchio#2047))
    - Raise exception on wrong input size in `XYZQUATToSE3` Python binding function ([2073](stack-of-tasks/pinocchio#2073))
    - Remove memory leak in `buildGeomFromUrdf` and `buildGeomFromUrdfString` Python binding functions ([2082]()stack-of-tasks/pinocchio#2082)
    - Fix Panda3D viewer examples ([2087](stack-of-tasks/pinocchio#2087))
    - Fix centroidal dynamics derivatives with respect to time ([2094](stack-of-tasks/pinocchio#2094)))

    ### Changed

    - Rename freeflyer_joint to root_joint in `humanoid` sample model ([2043](stack-of-tasks/pinocchio#2043))
    - CMake minimal version is now 3.10 ([2055](stack-of-tasks/pinocchio#2055))
    - Split headers and sources in different directories to have a more standard C++ project ([2070](stack-of-tasks/pinocchio#2070))

    ### Removed

    - Remove support to `hpp-fcl` < v2.0.0 ([2086](stack-of-tasks/pinocchio#2086))

    ## Packaging changes

    - removed patches ad, ae: fixed upstream 🎉
    - updated patches af, ah, an
    - added patch ao
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

@nim65s nim65s nim65s left review comments

Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pinocchio.XYZQUATToSE3(np.array([ ]) takes in any size of the array
3 participants
@jorisv @nim65s @jcarpent