Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depend on packaging module #2080

Closed

Conversation

singingwolfboy
Copy link

@singingwolfboy singingwolfboy commented Nov 8, 2023

Python's distutils module is deprecated, and has been removed from Python 3.12. Pinocchio is importing from distutils.version -- the recommended upgrade path for this is to switch to the packaging module, which includes utilities for version comparison.

Without this change, Pinocchio will not run on Python 3.12.

@hrp2-14
Copy link

hrp2-14 commented Nov 8, 2023

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@singingwolfboy singingwolfboy changed the base branch from master to devel November 8, 2023 09:13
@nim65s
Copy link
Contributor

nim65s commented Nov 8, 2023

Hi @singingwolfboy, and thanks for this proposition.

I don't think it is worth to add a dependency on packaging for this. I'm not sure how different package managers and different python versions would like this (I'm especiallly thinking about ROS here)

hpp-fcl v1.7.7 is kind of old, so we could basically raise the required version, which is currently 1.7.3 according to our main CMakeLists.txt.

Another option would be to trivially parse this version number, with eg. tuple(int(i) for i in hppfcl.__version__.split('.')) >= (1, 7, 7)

@jcarpent
Copy link
Contributor

cf #2086

@jcarpent jcarpent closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants