Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direct boost is_floating_point import #2103

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add direct boost is_floating_point import #2103

merged 2 commits into from
Nov 29, 2023

Conversation

ambyld
Copy link

@ambyld ambyld commented Nov 28, 2023

Add direct import of boost header containing boost::math::is_floating_point to avoid import error:

In file included from bazel-out/k8-opt/bin/external/com_github_stack_of_tasks_pinocchio/_virtual_includes/pinocchio/pinocchio/math/quaternion.hpp:12,
                 from bazel-out/k8-opt/bin/external/com_github_stack_of_tasks_pinocchio/_virtual_includes/pinocchio/pinocchio/spatial/se3-tpl.hpp:12,
                 from bazel-out/k8-opt/bin/external/com_github_stack_of_tasks_pinocchio/_virtual_includes/pinocchio/pinocchio/spatial/se3.hpp:44:
bazel-out/k8-opt/bin/external/com_github_stack_of_tasks_pinocchio/_virtual_includes/pinocchio/pinocchio/math/fwd.hpp:16:54: error: expected template-name before '<' token
   16 |   struct is_floating_point : boost::is_floating_point<T>
      |                                                      ^
bazel-out/k8-opt/bin/external/com_github_stack_of_tasks_pinocchio/_virtual_includes/pinocchio/pinocchio/math/fwd.hpp:16:54: error: expected '{' before '<' token

Seen in Pinocchio v2.6.21 with Boost 1.83.0.

jcarpent
jcarpent previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Very helpful.

@jcarpent jcarpent force-pushed the fix-floating-point-import branch from 8badd18 to 1f9b4c0 Compare November 29, 2023 07:55
@jcarpent jcarpent enabled auto-merge November 29, 2023 07:55
@jcarpent jcarpent merged commit 6bb26ad into stack-of-tasks:devel Nov 29, 2023
12 checks passed
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jan 27, 2024
@nim65s
[math/{py-,}pinocchio] Update to v2.7.0
86709d0 
Upstream changes:

    ## [2.7.0] - 2024-01-23

    ### Added
    - Add `GeometryObject::meshMaterial` attribute (stack-of-tasks/pinocchio#2084)

    ### Fixed

    - Use bp::ssize_t for recent version of Windows compilers (stack-of-tasks/pinocchio#2102)
    - Fix missing include for Boost >= 1.83 (stack-of-tasks/pinocchio#2103)
    - Remove f-strings to fix install with python 2 (stack-of-tasks/pinocchio#2110)
    - CMake: stop exporting CppAd/cppadcodegen & fetch submodule if not available (stack-of-tasks/pinocchio#2112)
    - Fix malloc issue in CRBA algo (stack-of-tasks/pinocchio#2126)
    - Fix build cppad and cppadcg with Boost < 1.77 (stack-of-tasks/pinocchio#2132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambyld @jcarpent