Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read k3s_token from secrets.yml file #540

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Read k3s_token from secrets.yml file #540

merged 5 commits into from
Jan 17, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 16, 2025

Allows this to be kept vault-encrypted rather than as a unencrypted terraform variable.

@sjpb sjpb requested a review from a team as a code owner January 16, 2025 17:53
wtripp180901
wtripp180901 requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one possible suggestion

environments/.stackhpc/terraform/main.tf Outdated Show resolved Hide resolved
@sjpb sjpb requested a review from wtripp180901 January 17, 2025 10:42
wtripp180901
wtripp180901 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 64cedcc into main Jan 17, 2025
1 of 2 checks passed
@sjpb sjpb deleted the feat/k3s-tf-secret branch January 17, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @wtripp180901