Commit dist when changes occurred. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaus67
force-pushed
the
dh/commit-dist
branch
from
cad0503 to
d6ebb24
Compare
Merged
|
As said in the description of the PR, typescript girhub action expect this and I don't want to force people to manually do this and pollute their PRs with the code changes. |
dhaus67
force-pushed
the
dh/commit-dist
branch
from
d6ebb24 to
226e04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable committing changes to the
distdirectory on pushes to main.The alternative is to have a check step which will detect if there's any changes to the dist file and require users to manually run
npm run alllocally + committing this before merging.Successful action run: https://github.com/stackrox/central-login/actions/runs/6741999434/job/18327406312
Resulting commit: cad0503