Revert "Bump k8s.io/apimachinery from 0.28.4 to 0.29.0 (#74)" #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d8db17. Helmtest builds fine, but stackrox/stackrox fails with: /go/pkg/mod/k8s.io/client-go@v0.28.4/transport/spdy/spdy.go:46:25: assignment mismatch: 1 variable but spdy.NewRoundTripperWithConfig returns 2 values make: *** [Makefile:223: vet] Error 1 because k8s.io/apimachinery@v0.29 is incompatible with k8s.io/client-go@v0.28.4
janisz
approved these changes
Dec 19, 2023
porridge
force-pushed
the
revert-apimachinery-bump
branch
from
0bf1554 to
b2baa4a
Compare
janisz
added a commit
that referenced
this pull request
Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0d8db17.
Helmtest builds fine, but stackrox/stackrox fails with:
because k8s.io/apimachinery@v0.29 is incompatible with k8s.io/client-go@v0.28.4
This also adds a minimal test that would fail to build on another attempt to do this bump, to prevent breaking again.