-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: match infra OCP credentialsMode with stackrox CI #1057
Conversation
A single node development cluster (infra-pr-1057) was allocated in production infra for this PR. CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.6-10-gbe78e79af4 to it. 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @redhat.com authuser: Or:
|
While the binding count was correct, the clusters did not come up. I'd like to blame this on quay.io outage Nov/8/24 but it might be something else:
|
@@ -8,3 +8,4 @@ sources: | |||
- https://github.com/stackrox/infra | |||
annotations: | |||
acsDemoVersion: 4.2.2 | |||
ocpCredentialsMode: Passthrough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I approved the PR...
Why is ocpCredentialsMode
a chart annotation and not a value in one of the secret configuration or additional values files?
The reason acsDemoVersion
is an annotation is that
- it describes the infra server behaviour (different demo version => different infra server behavior)
- frequently changes & needs history
- can be updated by automation & reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed like a good place for constants to me. If that is an anti-pattern it can move to Constants.yaml or somesuch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could start a values.yaml
that is checked into the repo and also put acsDemoVersion there.
stackrox/stackrox CI uses
credentialsMode: Passthrough
to reduce the number of IAM policy bindings. Infra should default to provide the same type of cluster. This PR provides a parameter to override the default.Testing
UI defaults for openshift-4-perf-scale: https://localhost:8443/cluster/gj-11-08-spotless-scissors-b