Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameters to cluster output #1083

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Nov 23, 2023

This adds the workflow parameters to the Cluster message.
They can be displayed with the --json output flag.
That helps with debugging cluster issues.
Example in https://github.com/stackrox/infra/pull/1083/files#diff-a524488ef8b52930f6ae26541a6af3de9b82377d553b237639908ef9aa9d2f72R216-R227.

I am not sure if this will require a version bump (is changing the message of a proto a breaking change? I think it might not be because of compatibility promises)

@tommartensen tommartensen self-assigned this Nov 23, 2023
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 23, 2023

A single node development cluster (infra-pr-1083) was allocated in production infra for this PR.

CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.7-20-g14ae9056c1 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1083 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen changed the title wip: add parameters to cluster info (server side) add parameters to cluster output Nov 23, 2023
@tommartensen tommartensen marked this pull request as ready for review November 23, 2023 17:39
@tommartensen tommartensen requested a review from a team as a code owner November 23, 2023 17:39
@tommartensen tommartensen merged commit c7f7b13 into master Nov 28, 2023
7 checks passed
@tommartensen tommartensen deleted the tm/add-parameters-to-cluster-info branch November 28, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants