Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about running on controller #278

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Oct 9, 2023

In the current implementation, running a scan on an Agent poses several challenges:

  • Backward Compatibility: Enforcing Agent-based scans creates compatibility issues since Agents may not always be configured to connect to ACS (External Service).
  • Serialization: We must ensure data is serialized to facilitate the transfer from an Agent to the Controller, allowing presentation of results to the user.
  • Testing Complexity: Extending our end-to-end testing with an additional Controller/Agent setup is required to adequately test Agent functionality. However, this introduces complexity into our testing process.

In light of these challenges, it is more practical to run scans on the Controller rather than the Agent.


Refs: https://issues.jenkins.io/browse/JENKINS-71622
Closes:

@janisz janisz requested a review from dhaus67 October 9, 2023 17:40
@janisz janisz added bug Something isn't working documentation Improvements or additions to documentation labels Oct 9, 2023
@janisz janisz requested a review from rukletsov October 12, 2023 10:34
@janisz janisz merged commit 4d3f4ee into master Oct 18, 2023
4 checks passed
@janisz janisz deleted the Add-information-about-running-on-controller branch October 18, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants