Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-21047: Widgets are hard to read #173

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

ludydoo
Copy link
Contributor

@ludydoo ludydoo commented Dec 8, 2023

Removed the AZ Memory/CPU utilization - In favor of the capacity planning dashboard

@ludydoo ludydoo requested a review from a team as a code owner December 8, 2023 11:46
@ludydoo ludydoo requested review from stehessel and removed request for a team December 8, 2023 11:46
@stehessel
Copy link
Contributor

Can you take a screenshot to review the changes? Alternatively save the updated dashboard under a new name, it will live until the Grafana pod is restarted.

@ludydoo
Copy link
Contributor Author

ludydoo commented Dec 8, 2023

Can you take a screenshot to review the changes? Alternatively save the updated dashboard under a new name, it will live until the Grafana pod is restarted.

Sure, I just sent you a link privately to the dashboard copy. Not many changes. Only remove 2 panels and add a "text", but the indentation results in the whole file having changes.

@stehessel
Copy link
Contributor

This dashboard displays the central memory usage over its limits (in %)

I think this is a bit confusing because "over" sounds like "above". How about This dashboard displays the central memory usage in percentage of the memory limit.

@stehessel
Copy link
Contributor

Can you fix the legend alignment on the left side of the widget? It got messed up in one of the last version bumps.

@ludydoo
Copy link
Contributor Author

ludydoo commented Dec 8, 2023

Can you fix the legend alignment on the left side of the widget? It got messed up in one of the last version bumps.

Not sure what you mean

@stehessel
Copy link
Contributor

Can you fix the legend alignment on the left side of the widget? It got messed up in one of the last version bumps.

Not sure what you mean

This is how the dashboard is rendered for me. Note that the left hand side legend is eaten.

Screenshot 2023-12-08 at 17 02 15

@ludydoo ludydoo force-pushed the ROX-21047-widgets-hard-to-read branch from b4411fc to 7ddf7b1 Compare January 9, 2024 11:52
@ludydoo
Copy link
Contributor Author

ludydoo commented Jan 9, 2024

@stehessel can you have another look?

@ludydoo ludydoo enabled auto-merge January 9, 2024 12:45
@ludydoo ludydoo merged commit 259c241 into master Jan 9, 2024
1 check passed
@ludydoo ludydoo deleted the ROX-21047-widgets-hard-to-read branch January 9, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants