-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-21530: Cert Expiry Dashboard #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludydoo
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stehessel
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more suggestions:
|
@aaa5kameric can you add new screenshots? |
/retest |
ludydoo
approved these changes
Nov 14, 2024
ludydoo
reviewed
Nov 14, 2024
ludydoo
reviewed
Nov 14, 2024
@stehessel can you re-review 🙏 |
stehessel
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 2 steps prior to this PR:
First step was to Implement monitoring for certificate expiration, tracking and managing of digital certificates expiration dates. Certificate Monitoring PR: ROX-21530-certificate-monitoring , extracts timestamps from certificates and exposes metrics to Prometheus.
The second step was the Alerting part. Certificate Alerting PR: ROX-21530-certificate-alerting depends on the monitoring phase for timestamp exposing and extraction. So, External dependencies: adding/extracting the metrics : ROX-21530-certificate-monitoring . In the alerting phase, we defined prometheus rules and tests (
RHACSFleetschardCertificateExpiring.yaml
) for timestamps expiring on:WARNING: <= 7 days
RHACSFleetshardCertificateExpiringSoon
CRITICAL: <=1 day
RHACSFleetshardCertificateExpiringCritical
Lastly, the Certificate Expiry Table-Dashboard was created using Grafana called
Certificates Expiry
. From the prometheus metric:acs_fleetshard_certificate_expiration_timestamp
. This table is located in theRHACS Dataplane - Cluster Metrics
section.Jira Ticket: https://issues.redhat.com/browse/ROX-21530
Dashboard Screenshots:
Link to draft dashboard:https://grafana-route-rhacs-observability.apps.acs-int-us-01.isbr.p1.openshiftapps.com/d/ae1jamsury800e/rhacs-dataplane-cluster-metrics-copy-amina-copy?orgId=1&from=1730045176177&to=1730131576177&viewPanel=148