Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests related to nginx image #1288

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix e2e tests related to nginx image #1288

merged 2 commits into from
Oct 12, 2023

Conversation

dcaravel
Copy link
Contributor

@dcaravel dcaravel commented Oct 12, 2023

Failure:

{Failed      sanity_test.go:126: 
        	Error Trace:	/go/src/github.com/stackrox/scanner/e2etests/sanity_test.go:126
        	Error:      	Not equal: 
        	            	expected: v1.Feature{Name:"nghttp2", NamespaceName:"alpine:v3.17", VersionFormat:"apk", Version:"1.51.0-r0", Vulnerabilities:[]v1.Vulnerability(nil), AddedBy:"sha256:4aacde79cec42c8d0c5886185e70a16b107ae8c6b1a67d63d6efdb6d6978ed97", Location:"", FixedBy:"1.51.0-r1", Executables:[]*scannerV1.Executable(nil)}
        	            	actual  : v1.Feature{Name:"nghttp2", NamespaceName:"alpine:v3.17", VersionFormat:"apk", Version:"1.51.0-r0", Vulnerabilities:[]v1.Vulnerability(nil), AddedBy:"sha256:4aacde79cec42c8d0c5886185e70a16b107ae8c6b1a67d63d6efdb6d6978ed97", Location:"", FixedBy:"1.51.0-r2", Executables:[]*scannerV1.Executable(nil)}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -8,3 +8,3 @@
        	            	  Location: (string) "",
        	            	- FixedBy: (string) (len=9) "1.51.0-r1",
        	            	+ FixedBy: (string) (len=9) "1.51.0-r2",
        	            	  Executables: ([]*scannerV1.Executable) <nil>
        	Test:       	TestImageSanity/nginx:1.25.0-alpine/nghttp2/1.51.0-r0}

@dcaravel dcaravel requested a review from a team October 12, 2023 16:11
@ghost
Copy link

ghost commented Oct 12, 2023

Images are ready for the commit at f94c51d.

To use the images, use the tag 2.31.x-26-gf94c51df09.

@dcaravel
Copy link
Contributor Author

Ugh, reverting layer change, with scanner update to read host architecture - my local testing was showing the arm64 layers.

@dcaravel
Copy link
Contributor Author

/test db-integration-tests

Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed this when adding the HTTP/2 vulns. Glad it worked 😂

@dcaravel dcaravel merged commit 7f94f67 into master Oct 12, 2023
@dcaravel dcaravel deleted the dc/fix-alpine-e2e branch October 12, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants