-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RHTAP references (klape/konflux-scanner-db-onboarding) #1386
Update RHTAP references (klape/konflux-scanner-db-onboarding) #1386
Conversation
Co-authored-by: red-hat-konflux <rhtap@redhat.com>
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6d29f34
to
7ce0973
Compare
Clair scan finds CVEs in the currently used image which has a pinned tag `registry.redhat.io/rhel8/postgresql-12:1-150.1698060555`. Previously, I insisted and we decided :-) that it's ok to unpin tags on certain Red Hat images and use `latest` instead. First, Red Hat base images such as `ubi8`/`rhel8` are quite stable and we did not experience anything breaking when switching to newer tags yet. I hope this applies to `rhel8/postgresql-*` just as well. Second, there is (was) no mechanism to auto-update tags in Konflux, and so the only way to get auto-update effect is by using floating tags.
7ce0973
to
f9ef4f6
Compare
similar to other components that we already onboarded. This is to make EC pass. Currently, it does not like labels and fails. See https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1706697920604029?thread_ts=1706696386.703799&cid=C05TS9N0S7L
I hope this might help with the observed error in logs ``` LibClamAV Error: cli_realloc(): Attempt to allocate 190846800 bytes. Please report to https://github.com/Cisco-Talos/clamav/issues ``` See also https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1706698737856699?thread_ts=1706696386.703799&cid=C05TS9N0S7L
f9ef4f6
to
ca7d9e6
Compare
GoLand considers (at least at some point did) `Dockerfile` to be an extension and so Dockerfile syntax highlighting works only when the file has `.Dockerfile` at the end. Obviously, `konflux.Dockerfile.slim` won't get this but I don't want to break the pattern with the existing `Dockerfile.slim`. Hopefully, this is not too confusing.
and synchronize between themselves
Used only reformat file hotkey, no manual changes.
because `clone-repository` already depends on that.
It's actually stolen from #1334 with small modifications.
looks more or less final at this point
because there will be a separate task for it: https://issues.redhat.com/browse/ROX-20750
so that we know the script completed and was not interrupted.
so that the pipeline corresponds stackrox/stackrox ones more.
ca7d9e6
to
43d7a81
Compare
43d7a81
to
66e8563
Compare
66e8563
to
166a021
Compare
166a021
to
889f599
Compare
This PR contains the following updates:
351af2c
->1ee1d57
f65a69a
->29a64be
To execute skipped test pipelines write comment
/ok-to-test